Replace sync.Once with sync.OnceFunc/OnceValue/OnceValues#4958
Merged
Conversation
Migrate all sync.Once usage to the typed helpers added in Go 1.21. Add a forbidigo lint rule to prevent sync.Once from being reintroduced. Co-authored-by: Isaac
Co-authored-by: Isaac
Member
|
What is the "why" behind this change? The lint rule is obvious to avoid it in the future but why do we want to avoid it? |
Contributor
Author
|
All Found these (and others) when going over the release notes of the past couple of Go releases. |
simonfaltum
approved these changes
Apr 14, 2026
denik
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.Onceusage tosync.OnceFunc,sync.OnceValue, orsync.OnceValuesforbidigolint rule to preventsync.Oncefrom being reintroducedbundle/direct/dresourcesThis pull request was AI-assisted by Isaac.